David Tolnay

Results 304 issues of David Tolnay

The canonical Debug implementation for **any** type that implements Deref is: ```rust Debug::fmt(&**self, formatter) ``` This principle came up during libs team discussion of https://github.com/rust-lang/rust/pull/48553.

amendment
T-libs
disposition-merge
needs-fcp
finished-final-comment-period

https://github.com/rust-lang-nursery/api-guidelines/issues/135#issuecomment-343698387 suggests a nice one: > I've been using `PascalCase!` for macros that expand into types. (e.g. `Array![i32; 5; 4; 3]` which expands into `[[[i32; 3]; 4]; 5]`) I did...

amendment
T-libs
disposition-merge
needs-fcp
finished-final-comment-period

https://github.com/rust-lang/rfcs/pull/1860#issuecomment-279848322 gives an interesting reason to consider not following the C-SMART-PTR guideline. In that case we decided to follow the guideline anyway, even though the motivation for the guideline does...

clarification
amendment
accepted

Along with a summary of the discussion and perspectives so far for each.

presentation

For example clicking on the "Macro syntax is evocative of the output" currently links to https://rust-lang-nursery.github.io/api-guidelines/macros.html#input-syntax-is-evocative-of-the-output-c-evocative. Instead it should link to https://rust-lang-nursery.github.io/api-guidelines/macros.html#c-evocative as the checklist does. This would allow us...

presentation

### What does this PR try to resolve? As flagged in https://github.com/rust-lang/cargo/pull/10079#issuecomment-1170940132, it's not great to assume that git SHAs would always be 40-character hex strings. In the future they...

S-waiting-on-review

# Meeting proposal info - **Title:** Standard library implementation ownership - **Type:** non-technical # Summary I am interested in whether it would make sense for the compiler team (or subteam...

meeting-proposal
meeting-scheduled

Overnight all three of our nightly, beta, and stable macos builds began failing with: ```console thread 'test' panicked at 'assertion failed: `(left == right)` left: `""`, right: `"target/debug/examples/print\na\nb\nc\n"`', tests/test.rs:19:5 ```

help wanted
macos

https://github.com/dtolnay/cargo-expand/blob/1a43c1c0dbf06f8296144a21b1de181f797c94d2/build.rs#L9-L11

help wanted

For example, avoid expanding `try!` and other macros inside the output of proc macros. cc @djc

enhancement