David Tolnay

Results 700 comments of David Tolnay

The `Deserializer` documentation is still wrong as of current master.

This isn't valid C++ code. The same thing wouldn't compile in plain C++ either. ```cpp #include template void Add() {} static int32_t NUMBER = 42; int main() { Add(); }...

> the cxx crate has the same problem. @ogoffart it doesn't, at least not in the context of https://github.com/mystor/rust-cpp/issues/19#issuecomment-331629593. They are interested in using a macro to generate a `CPlusPlusBox`...

I just mean that collecting why people reach for macros and solving those use cases in a better way is a viable way to make significant progress on this issue....

^ I specifically care about push notifications **on Android** for the **user dashboard** view. You can claim the bounty after solving that one, the other platforms can happen later.

Intel website moved the System V AMD64 ABI pdf so the link in the issue is broken -- here is an updated link: https://software.intel.com/content/dam/develop/external/us/en/documents/mpx-linux64-abi.pdf

I don't think this is a duplicated of #642. This is for a field attribute and that one is for a container attribute. They are useful in different situations.

The desired behavior: ```rust let data = b"[0] {"k":"v"} [1]"; let de = serde_json::Deserializer::from_slice(data); let mut stream = de.into_iter::(); assert_eq!(0, stream.byte_offset()); println!("{:?}", stream.next()); // [0] assert_eq!(3, stream.byte_offset()); println!("{:?}", stream.next()); //...

Thank you Lukas, your writeup is enormously helpful in evaluating this PR. One thing I would want to look into is whether any of the "small serde" redesigns (miniserde, deser,...

Here is a more concise implementation from #984: ```rust pub fn double_option, D: Deserializer