Daniel McCloy

> Maybe something to report upstream? I thought the only reason why `multi_dot` exists is because it is faster... I don't think so. I think it's faster *if you're careless...

This is not a valid EDF file. Quoting from [the original standard](https://www.edfplus.info/specs/edf.html): > 8 ascii : starttime of recording (hh.mm.ss) and [the EDF+ standard](https://www.edfplus.info/specs/edfplus.html), section 2.1.3: > 2. The 'startdate'...

where would folks look up the description if it's not obvious to them what it ought to be?

> #### Describe your proposed implementation > > Implement `mne.preprocessing.sgeyesub` following the [reference implementation](https://github.com/rkobler/eyeartifactcorrection). reference implementation is GPL-3, which IIUC carries a "same license for the library" requirement. We'd need...

@moritz-gerster there are some failing tests: style test: ``` =================================== FAILURES =================================== __________________________ test_docstring_parameters ___________________________ mne/tests/test_docstring_parameters.py:164: in test_docstring_parameters raise AssertionError(msg) E AssertionError: E mne.io.proj.make_eeg_average_ref_proj : PR01 : Parameters {'ch_type'} not...

> ``` > ================================== FAILURES =================================== > ___________________________ test_set_eeg_reference ____________________________ > mne\io\tests\test_reference.py:172: in test_set_eeg_reference > reref, ref_data = set_eeg_reference(raw, copy=False, projection=True) > E Failed: DID NOT WARN. No warnings of...

> For me this was confusing because I thought the great benefit of the projection is that I can easily turn it on- and off during plotting etc. I agree...

@alexrockhill just refactored the widgets after the 1.1 release, so there's a chance that this is already fixed on main. Can you check?

@dominikwelke FYI I've just tested the current state of the PR with an environment that uses scipy==1.8.0 and it worked fine. So I think we can chalk up the previous...

> i dont know what to change in the mne codebase, to add the new channel type. Once https://github.com/mne-tools/fiff-constants/pull/39 is merged, then here: https://github.com/mne-tools/mne-python/blob/386d4cf56551a248637c5291d5b1568dbcd26d1e/mne/io/constants.py#L182-L226