mne-python icon indicating copy to clipboard operation
mne-python copied to clipboard

Some Brain GUI widgets don't look good on Windows

Open hoechenberger opened this issue 1 year ago • 4 comments

I believe this screenshot illustrates my main issues:

image

  • The toolbar is filled with white nothingness
  • The "reset" rescale button is smaller than the plus and minus buttons
  • The plus and minus rescale buttons look weird, the symbols are not rendered in an expected way

This is on Windows 10 with MNE 1.1.

MWE:

# %%
import mne

mne.viz.set_3d_backend('pyvista')

sample_dir = mne.datasets.sample.data_path()
stc_fname = sample_dir / 'MEG' / 'sample' / 'sample_audvis-meg'  # omit suffix
fs_subject = 'sample'
fs_subjects_dir = sample_dir / 'subjects'

stc = mne.read_source_estimate(fname=stc_fname, subject=fs_subject)

brain = stc.plot(
    subject=fs_subject,
    subjects_dir=fs_subjects_dir,
    initial_time=0.1,
    views=('lateral', 'medial'),
    hemi='split',
    surface='inflated',
    size=(800, 500),
    background='white',
    time_viewer=True,
    show_traces=True,
    clim=dict(kind='value', lims=[3, 6, 9])
)

hoechenberger avatar Aug 11 '22 10:08 hoechenberger

@alexrockhill just refactored the widgets after the 1.1 release, so there's a chance that this is already fixed on main. Can you check?

drammock avatar Aug 11 '22 11:08 drammock

@alexrockhill just refactored the widgets after the 1.1 release, so there's a chance that this is already fixed on main. Can you check?

I need to use the new backend for the brain viewer, the backend is there but it's just not implemented anywhere. I think it should fix these kinds of issues.

alexrockhill avatar Aug 11 '22 15:08 alexrockhill

I think there is no way we can realistically fix this for 1.2 in the next week @hoechenberger as the proposed fix is to swap in the new Qt backend for Brain which is a big undertaking. Bumping the milestone...

larsoner avatar Sep 15 '22 17:09 larsoner

@larsoner I actually just added it to the milestone to remind myself to check whether the problem actually still exists :) Which I'll probably do tomorrow!

hoechenberger avatar Sep 15 '22 17:09 hoechenberger

Just to add to this, the help menu on macOS also covers some of the toolbar icons

Screenshot 2023-10-05 at 5 21 08 PM

larsoner avatar Oct 05 '23 14:10 larsoner

The menu should not be placed inside the window, but in the menu bar (which is detached and located at the top of the screen)

hoechenberger avatar Oct 05 '23 15:10 hoechenberger