Daniel McCloy

Results 258 comments of Daniel McCloy

> How about introducing an arbitrary threshold of, say, 3 or 5 (or even 1?); and spatial_colors defaulting to None, which will act as True for n_chs > threshold, and...

> I actually prefer (2) to (3) even if we can figure out a way to do (3) because it makes it clear you're actually getting back the original object...

> and be explicit for a method and only list the one type that it applies to because for methods that come from mixins, we don't know the type at...

> result : same type as the input data that's not a bad proposal in terms of clarity, but whatever we do has to pass `numpydoc` and/or be special-cased so...

crossrefs: - roadmap: https://mne.tools/dev/overview/roadmap.html#clustering-statistics-api - big discussion: #4859

> we're merely adding one new function and a new class, both of which are very slim. I think marking them as experimental ought to be enough. to make @larsoner's...

To flesh out the steps a little bit, I think a reasonable priority order would be: 1. make a copy of `examples/visualization/brain.py` (I'll call it `tumor.py` below) in the same...

...also along the way we'll want to make a public API `brain.add_mesh()` or so, to avoid accessing the private `._renderer` attribute in an example. But let's get it working first...

Just to be clear about what I think the proposals are: 1. **increase our max line length.** sure, +1 2. **Adopt `black` (with some suitable, possibly non-default configuration), run it...

> Is there something like pre-commit that will only run when you _push_ instead of when you _commit_? To answer my own question, apparently you can put any executable file...