Daniel McCloy

Results 258 comments of Daniel McCloy

this is still a draft but now would be a good time for some early feedback about code organization and API (ping @larsoner and @agramfort in particular, but input is...

> I am wondering about the use of spectrum. We use psd everywhere else. I chose "spectrum" because it's more general: e.g., depending on what parameters people use, sometimes we...

Other reasons to pick a new name: - people are used to things like `psds, freqs = psd_welch(raw)` so maybe (?) `raw.compute_psd()` might be similar enough to generate wrong expectations...

That was added to the list this week after conversations with @ajquinn. I think a follow up PR is probably best but if you disagree I can add it here....

- [new tutorial](https://output.circle-artifacts.com/output/job/e98a0c2d-c9ea-4c7c-adc5-f67ee86748aa/artifacts/0/dev/auto_tutorials/time-freq/10_spectrum_class.html#sphx-glr-auto-tutorials-time-freq-10-spectrum-class-py) - changed tutorial [sleep stage classification](https://output.circle-artifacts.com/output/job/e98a0c2d-c9ea-4c7c-adc5-f67ee86748aa/artifacts/0/dev/auto_tutorials/clinical/60_sleep.html#sphx-glr-auto-tutorials-clinical-60-sleep-py) - changed tutorial [raw plotting methods](https://output.circle-artifacts.com/output/job/e98a0c2d-c9ea-4c7c-adc5-f67ee86748aa/artifacts/0/dev/auto_tutorials/raw/40_visualize_raw.html#sphx-glr-auto-tutorials-raw-40-visualize-raw-py) - changed tutorial [visualizing epochs](https://output.circle-artifacts.com/output/job/e98a0c2d-c9ea-4c7c-adc5-f67ee86748aa/artifacts/0/dev/auto_tutorials/epochs/20_visualize_epochs.html#sphx-glr-auto-tutorials-epochs-20-visualize-epochs-py)

> Do we at some point want to support users creating their own `Spectral` instances like `EpochsArray` and `EvokedArray`? this is something I struggled with, and ultimately decided "YAGNI". But,...

`pip install git+https://github.com/jackz314/eeglabio` will install current `main` branch. If you want to make pull requests, then I'd first fork `eeglabio`, then ```sh git clone https://github.com/arnodelorme/eeglabio.git cd eeglabio git remote add...

> Would it be OK to include #6531 here? definitely. Cross-linking it should be sufficient, but free to edit the initial comment above to provide a summary of that issue...

crossref #7850 - problems with `plot_raw_sensors`: - axes title vs suptitle - seems to do tight_layout or similar adjustment when it shouldn't - callbacks appear to be linked between subplots?...