Daniel Orner

Results 405 comments of Daniel Orner

@McEileen when you say you couldn't get it working... what did you try, and what problems did you see?

Added a request - also, lint needs to be addressed.

Yeah. Probably the cleanest API would be something like: ``` # Model def reminder_schedule Schedule.new(self.reminder_schedule_definition) # maybe rename the column to this end ``` Then we don't have to assume...

You should be able to do a `fields_for :schedule_reminder` inside the form. You might need to do a bit of twiddling, but I don't think the form requires an ActiveRecord...

Wouldn't switching the donation form to use the same helper as purchases do what we need here?

@lenikadali yes, let's update the spec so it matches the new behavior.

@elasticspoon I don't think we need mini_racer in the Gemfile at all. I don't think it's used anywhere. Try removing it and see if anything breaks. :)

Looks good, but lint is failing and there is a merge conflict.