human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

4590 filtering on distribution

Open inane-pixel opened this issue 1 year ago • 1 comments

Resolves #4590

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checked "Total in Category" column does matches the total of the numbers in the column Test for "Total in Category Diaper"

Screenshots

inane-pixel avatar Oct 13 '24 13:10 inane-pixel

@inane-pixel This one also has changes that are not related to it. I think you branched off after having made the header changes in your main.

cielf avatar Oct 14 '24 13:10 cielf

Added a request - also, lint needs to be addressed.

dorner avatar Oct 27 '24 21:10 dorner

Hey @inane-pixel - Checking in because the issue has gone stale. There's still some requested changes on this.

cielf avatar Nov 13 '24 16:11 cielf

@cielf Sorry, I didn't see this until now. I fixed the lint issue, but I'm not sure when I'll have a chance to work on the test.

inane-pixel avatar Nov 13 '24 21:11 inane-pixel

Closing this as I finished up the work on this issue on #4806, which was just merged. Thanks @inane-pixel for this PR, it helped me get my bearings on the issue.

coalest avatar Dec 10 '24 11:12 coalest