Daniel Orner

Results 405 comments of Daniel Orner

I haven't found anything specific. You might need to put in some debug logs or an actual debugger session to see what Capybara is doing.

@GiovannyCordeiro can you merge main into your branch? I know this is taking a while but it's been busy on my end. Once the conflicts are solved I can hopefully...

@GiovannyCordeiro as long as the actual changes are small, the commit history should be squashable. I can look at this hopefully Friday.

Long story short, I've traced this all the way to here: [https://github.com/rubycdp/cuprite/blob/main/lib/capybara/cuprite/page.rb#L172](https://github.com/rubycdp/cuprite/blob/main/lib/capybara/cuprite/page.rb#L172) This sends a message via Chrome's DevTools Protocol which looks like this: ``` method: "Page.handleJavaScriptDialog", params: { accept:...

@GiovannyCordeiro unfortunately I don't have time to file an issue on the Cuprite repo. They'll probably want a more easily reproducible test case than "clone Human Essentials and run this...

So the test suddenly started passing locally. I'm wondering if a recent Chome update fixed it. 😮

@cielf the primary concern hasn't been addressed (the PR is still using JS ERB).

So I think we need to change the code here: [https://github.com/rubyforgood/human-essentials/blob/d648cb3fad29456633a927226bd1f0453e4e405c/spec/rails_helper.rb#L174-L174](https://github.com/rubyforgood/human-essentials/blob/d648cb3fad29456633a927226bd1f0453e4e405c/spec/rails_helper.rb#L174-L174) Right now it only forces true if the env variable is true. I think we need to force false...