human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard

Importing partners should have the same fields as adding a partner

Open cielf opened this issue 9 months ago • 20 comments

Summary

Add columns to the partner import to match partner add

Why

Streamlining partner onboarding -- if the info can be imported, banks won't have to go into every partner separately.

Details

Currently partner import has the name and email only

Partner Add has more

  • Default storage location
  • Group
  • Do you want this partner to receive emails for distributions....
  • Quota
  • Notes
  • Documents

Let's leave off documents for this iteration, but add the rest to the import.

Critera for completion

  • [ ] behaviour as described
  • [ ] tests to support the behaviour

cielf avatar Mar 02 '25 16:03 cielf

Hi, I'd like to work on this, please.

McEileen avatar Mar 09 '25 13:03 McEileen

Please do!

cielf avatar Mar 10 '25 00:03 cielf

Hi @cielf, quick question. Do you have a preference for the order of the headers in the csv files to import partners? (I'm planning on creating a new example csv file that will include the additional fields, which is why I ask.) Would you like it to match the order of the fields in the issue, or the order of the fields shown below in the partner model's Schema Information?

# == Schema Information
#
# Table name: partners
#
#  id                          :integer          not null, primary key
#  email                       :string
#  name                        :string
#  notes                       :text
#  quota                       :integer
#  send_reminders              :boolean          default(FALSE), not null
#  status                      :integer          default("uninvited")
#  created_at                  :datetime         not null
#  updated_at                  :datetime         not null
#  default_storage_location_id :bigint
#  organization_id             :integer
#  partner_group_id            :bigint
#

(I know I'm not adding all of the above to the import functionality, I just copied and pasted the schema information to provide a reference in this thread.)

Thanks!

McEileen avatar Mar 15 '25 18:03 McEileen

@McEileen -- My initial take is that the best way, consistency-of-experience-wise, would be to have them in the same order as in the "add partner" screen. Does that make sense to you?

cielf avatar Mar 15 '25 21:03 cielf

@cielf Yes, that makes sense. Thanks.

McEileen avatar Mar 16 '25 16:03 McEileen

Let's leave group off as well.

cielf avatar Mar 23 '25 15:03 cielf

The default storage location should be the name of the default storage location.

cielf avatar Mar 23 '25 15:03 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Apr 23 '25 00:04 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Apr 30 '25 00:04 github-actions[bot]

This is in progress of review. Reassigning.

cielf avatar Apr 30 '25 12:04 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jun 01 '25 00:06 github-actions[bot]

Still in review process.

cielf avatar Jun 02 '25 15:06 cielf

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Jul 03 '25 00:07 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Jul 11 '25 00:07 github-actions[bot]

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Aug 11 '25 00:08 github-actions[bot]

Due to capacity constraints, I will be taking a pause from contributing to Human Essentials for a bit. I encourage anyone who is interested to pick up this issue. You are welcome to build off the PR I started, #5171.

McEileen avatar Aug 14 '25 01:08 McEileen

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] avatar Oct 15 '25 00:10 github-actions[bot]

Automatically unassigned after 7 days of inactivity.

github-actions[bot] avatar Oct 22 '25 00:10 github-actions[bot]

Hello, it looks like this has been marked inactive and stale. I would like to work on this please!

ParsannaK avatar Nov 13 '25 18:11 ParsannaK

Sorry for the delay - it's yours!

dorner avatar Nov 29 '25 23:11 dorner