Daniel Orner
Daniel Orner
Re the PDF testing - did you look at https://github.com/rubyforgood/human-essentials/blob/d8fa236212a4114d962d4f7ac1002f42ba058c2e/lib/test_helpers/pdf_comparison_test_factory.rb ?
I think we do need to validate the results in the PDF. If you don't think you'll be able to do that kind of work, I'd rather bump the difficulty...
Unfortunately you can't use the ID directly in the PDF, because the ID will be different depending on the order of the specs passing. Here's my recommendation: Add the value...
hmm... maybe? I'd try without it and if it doesn't work, you can convert the string. I'm not 100% sure either of those will work though... You might need to...
@hagiya0121 I'm good with that!
Fixed for the events_read cases (both within event time and before it).
That's great! I started looking into this and ran into some issues with the generation of comments from C code: https://github.com/lsegal/yard/issues/1614 If I can't get this resolved, another option would...
Question - is there a reason our current code uses `call-seq` statements? It seems like that would be used for `rdoc`, but I can't seem to run `rdoc` on that...
I can see that the comments are already copied to the Java files... maybe it makes sense to have the "dummy" Ruby files be the source of truth for these...
That's pretty exciting! But it accomplishes different things. RBS files generally don't have comments explaining the "why" and "how" behind methods, just the "what". It's more for IDE integration. The...