human-essentials icon indicating copy to clipboard operation
human-essentials copied to clipboard
verified publisher icon rubyforgood

4976 product drive participant dropdown fix

Open tbenny001 opened this issue 11 months ago • 3 comments

Resolves #4976

Description

When creating a new donation and choosing Product Drive as the source, the Product Drive Participant drop down displays a blank entry when the participant has no business name. This PR addresses this issue by falling back to the contact name of the product drive participant if the participant does not have a business name.

Also adding DockerDesktopWSL/ to the .gitignore file

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

New Rspec tests and manual verification

Screenshots

Creating a Product Drive Participant with no business name: image

Before: Screenshot (3)

After: Screenshot (4)

tbenny001 avatar Feb 09 '25 10:02 tbenny001

Hey @cielf, sorry for the late response! I just pushed up the fix. It should work for the New Donation page as well now.

tbenny001 avatar Feb 23 '25 02:02 tbenny001

Looks good, but lint is failing and there is a merge conflict.

dorner avatar Feb 26 '25 00:02 dorner

@tbenny001 has had to bow out - so this is open for someone else to take it the last mile.

cielf avatar Mar 07 '25 19:03 cielf

It looks like a different PR resolved the issue in the meantime. Closing.

cielf avatar Aug 30 '25 20:08 cielf