Damien Mathieu
Damien Mathieu
cc @pyohannes @akats7 as code owners.
This suggestion makes sense. Do you want to work on a PR?
There is a plugin that allows doing that more broadly than just within otelhttp. https://github.com/MrAlias/redact
See https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/instrumentation#new-instrumentation Why does this need to be a plugin in this repository? Can't Datadog provide that in their own organization? Would you be code owner for that plugin (and...
Adding tests shouldn't need a changelog entry. Also, what is preventing those tests from residing in the same package as the code?
Closing this, as with Go 1.23, the toolchain directive is required and added automatically.
> do you have an idea why the test fails.. It's a bit weird. I'm not getting a failure locally. As if sometimes, a 200 is returned (giving the error...
The non-deprecated runtime uses [runtime/metrics](https://pkg.go.dev/runtime/metrics) to retrieve metrics data. The metrics we exposed are documented in [semantic conventions](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/runtime/go-metrics.md). It looks like you're looking for [go.memory.allocated](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/runtime/go-metrics.md#metric-gomemoryallocated) and [go.memory.used](https://github.com/open-telemetry/semantic-conventions/blob/main/docs/runtime/go-metrics.md#metric-gomemoryused). The current runtime...
cc @dashpole who led this.
The linked issue in the description seems unrelated to this PR. Note that we won't be able to merge this until 1.25 is released (which is when we will drop...