Damien Mathieu

Results 562 comments of Damien Mathieu

This hasn't been updated in quite a while. Unassigning so someone else can pick it up (feel free to open a PR and link this issue in it, assignments are...

See the comment raised in https://github.com/open-telemetry/opentelemetry-go/issues/2632#issuecomment-1048809138 This is not a good idea until we have a proper way to disable tracing, which should first be a spec change. Disabling tracing...

This is a very large that seems to do more than just add unit tests (it switches proto-go from the slim package to the standard one for one). Should that...

See also https://github.com/open-telemetry/opentelemetry-go-contrib/issues/6908 for the same issue in the handler part.

Thinking about this, I'm not seeing any side effects doing this could have, and your issue does make sense. Do you want to open a PR with this fix and...

The runtime metrics we provided are documented in semantic conventions. See https://github.com/open-telemetry/semantic-conventions/blob/main/docs/runtime/go-metrics.md Before we can add new metrics, we'd need to update the semconvs.

I'm 👎 for this. While this may be a short term solution, it's bad design, and the kind of technical debt that would take a while to clean up (while...

Should we do this every time we use the body wrapper? https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-go-contrib%20NewBodyWrapper&type=code