Damien Mathieu

Results 562 comments of Damien Mathieu

Coming back at this, I don't think it's a good thing to add. Metrics should be low cardinality, and this really opens a big window for folks to shoot them...

What attributes are you adding?

Related: https://github.com/open-telemetry/opentelemetry-specification/discussions/4311

Unfortunately, due to a change in the way profile attributes are handled, this brings a breaking change to contrib, which isn't really fixable (we can read the data from the...

Based on the feedback from this document, I have changed the document to use a subpackage, named `collector`. > are there conflicts with agent startup? There shouldn't be. Importing a...

It has not. That is why the receiver can't be part of collector-contrib and will need its own distribution. We can implement the API and have our requirements in our...

Should this PR be merged?

This would need a [specification](https://github.com/open-telemetry/opentelemetry-specification/) change.

While this SDK doesn't implement it yet, the (unstable) `OnFinish` hook for processors would be a good place to mutate spans if they include an error. I think a custom...

There are a few more occurences. Want to fix them too? https://github.com/search?q=repo%3Aopen-telemetry%2Fopentelemetry-go+%22%2F%2Fnolint%22&type=code