opentelemetry-go-contrib
opentelemetry-go-contrib copied to clipboard
Add unit tests for host instrumentation
Resolve https://github.com/open-telemetry/opentelemetry-go-contrib/issues/2755
Codecov Report
Merging #3517 (980873e) into main (83a9d91) will increase coverage by
1.9%. The diff coverage is100.0%.
Additional details and impacted files
@@ Coverage Diff @@
## main #3517 +/- ##
=======================================
+ Coverage 69.9% 71.9% +1.9%
=======================================
Files 147 147
Lines 6934 6934
=======================================
+ Hits 4851 4988 +137
+ Misses 1959 1807 -152
- Partials 124 139 +15
| Impacted Files | Coverage Δ | |
|---|---|---|
| instrumentation/host/host.go | 76.2% <100.0%> (+76.2%) |
:arrow_up: |
Adding tests shouldn't need a changelog entry. Also, what is preventing those tests from residing in the same package as the code?
@dmathieu
- change log will be removed
- By adding these tests to a separate
testsub-directory, we can avoid unnecessary dependencies on the metric SDK in thehostdirectory.
@Petrie, are you still willing to work on this?