Damien Mathieu
Damien Mathieu
Histogram buckets are defined by the specification. https://github.com/open-telemetry/opentelemetry-specification/blob/0a78571045ca1dca48621c9648ec3c832c3c541c/specification/metrics/sdk.md#explicit-bucket-histogram-aggregation Changing this behavior would require a specification change. Do you want to bring your use case there? Note: I'm not sure this...
Yes, documenting this in godoc makes a lot of sense.
I'm slightly surprised this worked and hasn't been changed since 2021 (https://github.com/open-telemetry/opentelemetry-collector/pull/3464).
If we have been without this for so long, do we even need the opts?
@tasdikrahman are you still working on this?
This hasn't been updated in quite a while. Unassigning so someone else can pick it up (feel free to open a PR and link this issue in it, assignments are...
mdatagen is used by many packages. When making changes to the templates, you should regenerate everything with the `make gogenerate` command, and ensure every package still works.
I think `gogenerate` should keep running `gofmt`. Templates can be harder to properly format than actual Go files. Removing `goimport` from there may make sense though. Your PR still has...
I feel like this would break the specification requirements: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/data-model.md#type-any @pellared what do you think about this proposal?
@Jesse0Michael should we close this issue?