Damien Mathieu

Results 562 comments of Damien Mathieu

Could you add tests? (and fix the failing CI checks)

I think it does require a changelog entry. This changes the behavior of a public method in a public package.

While there could always be hacky ways to do this, OTLP relies on protobuf and gRPC, and the gRPC folks have explicitly said support for UDP is not on their...

I would recommend setting up the sampler on your own GitHub account instead. When we add support for the `OTEL_TRACES_SAMPLER` variable, we can make it rely on repositories from any...

No, it's more about showing intent of ownership. If you maintain a module for a while, it's much easier to discuss moving it back, since we can see the work...

Could you avoid force-pushing? That breaks the GitHub review interface.

Please avoid force-pushing PRs. That breaks the review process.

This is probably a local issue, because this step runs in CI fine: https://github.com/open-telemetry/opentelemetry-proto/actions/runs/13553922698/job/37883835301 Which brings another point. The gen-x commands are meant for CI validation. We provide a built...

Discussion on the same subject in the Go repository: - https://github.com/open-telemetry/opentelemetry-go/issues/4536 - https://github.com/open-telemetry/opentelemetry-go/issues/5129