Dylan T.
Dylan T.
Please also ask these guys to change their name: https://reports.ofsted.gov.uk/provider/21/102392 It's in Middle**sex** so this is a really terrible issue for the little kids.
> Do we follow Mojang's entity save format within PM? Just asking because a save key with a comparable functionality does not exist according to the [wiki](https://minecraft.fandom.com/wiki/Entity_format). That's precisely why...
`isUnderwater()` is not the same as `isInWater()`, which is what we would need for the surface swimming.
Actually this whole change doesn't make any sense. Any modification to `$item` should be automatically synced to the inventory.
Closing this since the solution is incorrect. The cause of the problem is described in #5220.
I don't think "forgot to check" counts as "intentionally". The rest of the points I acknowledge.
To be clear, I'm unconcerned about breaking broken use cases; forgetting to check a permission is highly likely to be a security vulnerability and server owners can easily grant appropriate...
Retargeting this to next-major out of an abundance of caution.
addendum to c): `setCancelled($cond)` is a bug in most cases.
There are some problems with this PR primarily involving pre-cancelled events being emitted by core code. In some cases events are cancelled out of the box (for example spectator mode...