Dylan T.

Results 460 comments of Dylan T.

At the least, there should be a small docblock that describes what the function does, since the function's name is not very intuitive.

I think `sendToastNotification()` or `sendToastMessage()` makes the most sense, since both `sendToast()` and `sendNotification()` are ambiguous at first glance.

This PR is a PM-side implementation of pmmp/RakLib#52. The performance change caused by this PR has not yet been assessed in detail, however I note the following points: - Per-session...

https://github.com/pmmp/Snooze/commit/b93dfe9d4c62a4eb8411885abd0bd46ce09cfc67 significantly improves the performance of having many notifiers; however, the problem remains how we get those notifiers installed in the first place.

Personally I was far more confused by onCommand() but that's a topic for a separate issue.

> if we think about fact, that these functions are in «PluginManager» yes, indeed

You can do this yourself using AddPlayerPacket now, but I recognize the need to be able to do this without touching the protocol.

This is most likely the fault of `Entity->isUnderwater()`, which uses the eye height to determine whether the entity's head is underwater. Perhaps the eye height when swimming is incorrect.

The text is not the same after rejoining the server. Before (using white dye) ![image](https://user-images.githubusercontent.com/14214667/147952951-7ac12506-ad1e-4688-afa7-9a8d6e86ae9d.png) After ![image](https://user-images.githubusercontent.com/14214667/147953002-7d0243e4-97a0-4c8f-9987-36dd1bf03ff2.png)