Dylan T.
Dylan T.
This is implemented completely incorrectly. Don't use the wiki for your source of information.
- The text is not supposed to glow unless using `Glow Ink Sac`, which is not currently implemented:  - The glow of text can be removed by using `Ink...
- There are also sounds that should be played when using dye or ink sacs on signs.
There are still unresolved review comments.
I've made some modifications to the PR, to handle `TextIgnoreLegacyBugResolved` properly, tidy up the code and improve some doc comments.
> Why does code style fail? on the actual php file its one line, on the log it shows + then -. You've left trailing whitespace on the line. Blank...
You need to submit a pull request to the master branch of this repo to add the string to `eng.ini`: https://github.com/pmmp/Language Once that's done, the `resources/locale` submodule should be updated...
You can pull it yourself, if you want to. ``` cd resources/locale git checkout master git pull cd ../.. git add resources/locale ``` and then commit as you would normally.
This has lots of side effects and potential ramifications that haven't been explored. There is a reason I haven't already done this myself. This will cause behavioural changes in many...
> I think the code for calling `Block::onEntityLand()` should be moved from Living to Entity while leaving the fall damage code in Living instead of creating boilerplate for this use...