metrics-server icon indicating copy to clipboard operation
metrics-server copied to clipboard

docs: point helm chart repo to metrics server github

Open ajayk opened this issue 2 years ago • 3 comments

docs: point helm chart repo to metrics server github Signed-off-by: ajayk [email protected]

What this PR does / why we need it: This Pr changes the reference of the helm chart to metrics server github instead of the deprecated chart

ajayk avatar Oct 01 '22 21:10 ajayk

Welcome @ajayk!

It looks like this is your first PR to kubernetes-sigs/metrics-server 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/metrics-server has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Oct 01 '22 21:10 k8s-ci-robot

Hi @ajayk. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 01 '22 21:10 k8s-ci-robot

/assign @dgrisonnet @logicalhan

logicalhan avatar Nov 03 '22 16:11 logicalhan

/lgtm

/assign @serathius

dgrisonnet avatar Nov 07 '22 11:11 dgrisonnet

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ajayk, liangyuanpeng, logicalhan

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 07 '22 19:11 k8s-ci-robot

/lgtm

CC @serathius

stevehipwell avatar Dec 29 '22 15:12 stevehipwell

/approve

serathius avatar Dec 29 '22 21:12 serathius

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: ajayk, liangyuanpeng, logicalhan, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 02 '23 11:01 k8s-ci-robot