David Eads

Results 240 comments of David Eads

PRR lgtm, thanks for the updates. /approve The sig still owns the overall KEP lgtm/approve

> How stable are the metrics you are using to verify that this feature works? > > `cronjob_controller_rate_limiter_use` and `cron_job_creation_skew` are they stable enough to be promoted in stability level?...

/milestone v1.27 /label lead-opted-in /stage beta

Scheduler should install and update before any other component so that new scheduling techniques can be used. /hold

other pieces need to be updated, but this looks reasonable /approve

Back in october the PRR was approved https://github.com/kubernetes/enhancements/pull/3298#issuecomment-1283041979 There was a new question added to scalability: https://github.com/kubernetes/enhancements/blob/master/keps/NNNN-kep-template/README.md#scalability , but that should be easy to update.

Glad to see gating be used to good purpose. Targeted at TechPreview (not default), I'm in favor. /approve