enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard

KEP-2885 Field Validation 1.27 GA graduation

Open kevindelgado opened this issue 2 years ago • 4 comments

  • One-line PR description: Update Field Validation to GA 1.27
  • Issue link: https://github.com/kubernetes/enhancements/issues/2885
  • Other comments: /cc @apelisse @liggitt @deads2k

kevindelgado avatar Jan 11 '23 17:01 kevindelgado

other than the gate removal timeline, lgtm

liggitt avatar Jan 13 '23 21:01 liggitt

Thanks, all feedback addressed.

/assign @deads2k for prod-readiness

kevindelgado avatar Jan 13 '23 21:01 kevindelgado

@kevindelgado: GitHub didn't allow me to assign the following users: for, prod-readiness.

Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to this:

Thanks, all feedback addressed.

/assign @deads2k for prod-readiness

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 13 '23 21:01 k8s-ci-robot

This lgtm for apimachinery and PRR

/lgtm /approve /hold

I'm holding so that @lavalamp gets a chance to comment on the statement of future intent: https://github.com/kubernetes/enhancements/pull/3725#discussion_r1084501801

Feel free to release when he's happy with that statement.

deads2k avatar Jan 23 '23 20:01 deads2k

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, kevindelgado

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jan 23 '23 20:01 k8s-ci-robot

/tide merge-method-squash

deads2k avatar Jan 24 '23 18:01 deads2k

updated wording is ok with me.

/lgtm /hold cancel

deads2k avatar Jan 24 '23 18:01 deads2k