enhancements icon indicating copy to clipboard operation
enhancements copied to clipboard
verified publisher icon kubernetes

KEP-3107: target csiNodeExpandSecret beta in 1.27

Open humblec opened this issue 3 years ago • 7 comments

Signed-off-by: Humble Chirammal [email protected]

  • One-line PR description:
  • Issue link: https://github.com/kubernetes/enhancements/issues/3107
  • Other comments:

humblec avatar Sep 21 '22 12:09 humblec

/assign @xing-yang

humblec avatar Sep 21 '22 12:09 humblec

Please update the following:

  1. Update PRR yaml file to Beta: https://github.com/kubernetes/enhancements/blob/master/keps/prod-readiness/sig-storage/3107.yaml#L5

  2. e2e tests requirements For a KEP targeting Beta to be merged, e2e tests need to be merged and added to the test grid. Once tests are added, update the KEP with a link to the tests: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3107-csi-nodeexpandsecret#e2e-tests

  3. The existing KEP only has the first section of PRR filled out. Please fill out the remaining sections which are required for Beta: https://github.com/kubernetes/enhancements/tree/master/keps/sig-storage/3107-csi-nodeexpandsecret#production-readiness-review-questionnaire

xing-yang avatar Sep 21 '22 13:09 xing-yang

@xing-yang I have added the PRR change and attempted template completion. ptal. .thanks !

humblec avatar Sep 22 '22 12:09 humblec

https://github.com/kubernetes/enhancements/pull/3531/files#r978671231 e2e tests need to be added before this KEP targeting Beta can be merged.

xing-yang avatar Sep 26 '22 15:09 xing-yang

/assign @deads2k

For PRR (although still missing SIG approval)

wojtek-t avatar Nov 21 '22 12:11 wojtek-t

Cc @zhucan

humblec avatar Jan 12 '23 10:01 humblec

I have addressed the final comment @jpbetz .. thanks :+1:

humblec avatar Feb 04 '23 04:02 humblec

/lgtm for PRR /assign @deads2k

jpbetz avatar Feb 04 '23 04:02 jpbetz

@deads2k I have addressed the final comment . Can you please review/approve this ? Thanks !

humblec avatar Feb 08 '23 13:02 humblec

From SIG Storage, we are waiting for this e2e test PR to be merged and shown in the test-grid:

https://github.com/kubernetes/kubernetes/pull/115451

xing-yang avatar Feb 08 '23 15:02 xing-yang

@deads2k I have addressed the final comment . Can you please review/approve this ? Thanks !

Thanks. The answer looks good. I'm not sure if a bot will require you to use the exact question format from the template, but that is minor.

PRR lgtm

/approve

deads2k avatar Feb 08 '23 16:02 deads2k

Thanks @deads2k :+1:

humblec avatar Feb 08 '23 17:02 humblec

The PR to add the e2e test to test-grid is merged: https://github.com/kubernetes/test-infra/pull/28681 I'll merge the KEP.

xing-yang avatar Feb 09 '23 17:02 xing-yang

/lgtm /approve

xing-yang avatar Feb 09 '23 17:02 xing-yang

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, humblec, xing-yang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 09 '23 17:02 k8s-ci-robot