Disable internalTrafficPolicy=Local service tests for cilium

[pperiyasamy]

The Cilium CNI plugin currently does not support services with internal traffic local policy, so skipping such relevant tests running against environments configured with cilium as primary network plugin.

For more information:

https://github.com/cilium/cilium/issues/17796 https://github.com/cilium/cilium/pull/17828

Signed-off-by: Periyasamy Palanisamy [email protected]

[deads2k]

I'm not sure if this is a bug. How does a user know this feature isn't working in their cluster?

/assign @danwinship

[danwinship]

I'm not sure if this is a bug. How does a user know this feature isn't working in their cluster?

Because they read the Cilium documentation and wouldn't have chosen to use Cilium if they needed this feature. ("But the Cilium documentation doesn't mention that they don't support this!" :man_shrugging:)

Currently third-party CNI plugin certification in OCP requires passing all networking Conformance tests, but we don't check non-conformance stuff, other than NetworkPolicy, which we allow them to fail some tests in, as long as they document it in their "using with openshift" docs. (We probably ought to do that with all non-conformance networking tests...)

FTR, Cilium is currently only certified against OCP 4.6 and 4.7, which are pre-internalTrafficPolicy anyway so this doesn't even apply to any version of Cilium+OCP that customers could currently be using.

[danwinship]

@pperiyasamy was going to investigate what the purpose of this CI job is, since it's hard to say whether disabling the test is appropriate or not without knowing why the job is being run

/hold

[jerpeter1]

what the purpose of this CI job is, since it's hard to say whether disabling the test is appropriate or not without knowing why the job is being run

It looks like the job was added in this PR. As described, the periodic jobs were added to test compatibility of cilium on openshift on aws, azure & gcp.

[pperiyasamy]

@danwinship as Jeremy pointed this CI job is added to test compatibility of cilium with OCP cluster. The cilium still skips running internalTrafficPolicy=Local test cases, i think we could also skip such test cases. So are we good to review and merge this ?

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pperiyasamy Once this PR has been reviewed and has the lgtm label, please assign pweil- for approval by writing /assign @pweil- in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• cmd/OWNERS
• test/extended/util/annotate/OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci[bot]]

@pperiyasamy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	227db4533ceb519caf4e4f1e9129966eb122d13a	link	true	/test verify
ci/prow/e2e-aws-single-node-upgrade	227db4533ceb519caf4e4f1e9129966eb122d13a	link	false	/test e2e-aws-single-node-upgrade
ci/prow/e2e-metal-ipi-ovn-ipv6	227db4533ceb519caf4e4f1e9129966eb122d13a	link	false	/test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-gcp	227db4533ceb519caf4e4f1e9129966eb122d13a	link	true	/test e2e-gcp
ci/prow/e2e-gcp-upgrade	227db4533ceb519caf4e4f1e9129966eb122d13a	link	true	/test e2e-gcp-upgrade
ci/prow/e2e-aws-csi	227db4533ceb519caf4e4f1e9129966eb122d13a	link	false	/test e2e-aws-csi

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[pperiyasamy]

Closing the PR as per this comment.