David Ostrovsky

Results 51 comments of David Ostrovsky

Same here, Gerrit Code Review project uses indirectly parboiled 1.1.6. Since upgrade to GWT 2.7 (that was updated to use asm 5.0.3) markdown parser doesn't work any more. Solution is...

Well, Bucklets were extracted from Gerrit Code Review project. But this specific condition shoudn't be Gerrit specific at all. Snapshot artifacts on Maven Central have the same characteristics as on...

Change under review: [1]. [1] https://gerrit-review.googlesource.com/59723

Just to make sure: This repository was moved to gerrit-review [1]. Have you cloned it from there? [1] git clone https://gerrit.googlesource.com/bucklets

Added Warning to README and link to the right repository.

Updated the Github repo with newest version: remove usage of `genfile()` as this is considered to be deprecated and going to be removed. PTAL.

I will keep this repo in sync with gerrit. And i think it's easy for hte folks report here issues. So i suggest to use this one. I am going...

This fragment (borrowed from [Gerrit Code Review](https://gerrit.googlesource.com/)), `proto/BUILD`: ``` load("@rules_java//java:defs.bzl", "java_proto_library") load("@rules_proto//proto:defs.bzl", "proto_library") proto_library( name = "cache_proto", srcs = ["cache.proto"], ) java_proto_library( name = "cache_java_proto", visibility = ["//visibility:public"], deps =...

-1. Current design is not only valuable but also the way I would expect it to work. I don't want to care what EP version a specific Bazel version is...

Say EP is not decoupled from Bazel and there is no `--incompatible-use-error-prone-version-2.3.4` added. Say EP 2.3.4 introduced breaking changes, e.g.: https://github.com/google/error-prone/commit/11e28aaa800c3fb716dad46944e88dac68c951fa, https://github.com/google/error-prone/commit/5ad37b7a2efd231dff6e6acde406a6846dfe150b that will break every Bazel user, who is...