David Ostrovsky
David Ostrovsky
Tring to build recent master 76586a45847dcc6776b3c594530a474432f9f058 reveals that one unit test is broken: [1]. is this expected? [1] http://paste.openstack.org/show/148477/
Running buildifier in fix mode is adding `to_list()` method, that breaks the code: ```diff diff --git a/closure/compiler/closure_js_library.bzl b/closure/compiler/closure_js_library.bzl index e3cc389..9139942 100644 --- a/closure/compiler/closure_js_library.bzl +++ b/closure/compiler/closure_js_library.bzl @@ -307,7 +307,7 @@ def...
Gerrit Code Review project is optionally supporting [Bazelisk](https://github.com/bazelbuild/bazelisk), by providing `.bazelversion` file. In the same time, we are checking the minimum supported Bazel version in `WORKSPACE` file by using bazel_skylib's...
On 23.04.202, Ubuntu 20.04 was released: [1]. What is the ETA for the Ubuntu 20.04 based RBE image? The reason I'm asking is that for Gerrit Code Review project we...
I'm trying to migrate from bazel-toolchain 5.0.0 to 5.1.0, where support for `rbe_autoconfig` was discontinued. In bazel-toolchain 5.0.0 I used this code to build against JDK 11: ```python http_archive( name...
I generate RBE config using this command: ``` $ ./rbe_configs_gen \ --bazel_version=4.1.0 \ --toolchain_container=l.gcr.io/google/rbe-ubuntu18-04:latest \ --output_src_root=/home/davido/projects/gerrit \ --output_config_path=tools/rbe \ --exec_os=linux \ --target_os=linux ``` and running the latest `buildifier` utility on...
On our CI docker we install Bazel version from the official Debian image, that corresponds to the `.bazelversion` file, by using official Bazel version: https://releases.bazel.build/1.0.0/rc2/bazel_1.0.0rc2-linux-x86_64.deb In the same time we...
It would be great to extend gerrit verification job to run also on RBE (like Bazel itself). Something like this works for me: ```sh $ bazel test --config=remote --remote_instance_name= javatests/......
Gerrit code currently has disabled two test groups because of timeout on Bazel CI. See this CL: [2]. Can someone please verify, if Bildkite CI works now and we could...
It would be helpful if assumption violations would be reflected on the text UI. For this test class with three test methods: ```java package org.gerritcon.mv2016; import static org.junit.Assert.assertEquals; import static...