David Ostrovsky

Results 53 comments of David Ostrovsky

> In order to migrate, I'd personally start with reading the docs for bazel-toolchains 5.x and try to set it up from scratch - as rbe_autoconfig is completely gone, there...

> What parameter should I pass to rbe_configs_gen to generate something equivalent to checked in rbe_jdk11, but for Bazel 4.1.0 (and for newer Bazel releases for that matter)? This seems...

@smukherj1 Thanks for clarifying. I can look into sending a PR once the prerequisites are met.

@philwo Are you working on it? I also tried to add custom docker image from Bazel in Gerrit, in patch set 4 of this change: [1] but I have not...

Update: I figured out how to build with JDK 11 and even produce major bytecode version 55 with RBE: [1]. [1] https://gerrit-review.googlesource.com/c/gerrit/+/291943

Update: it seems that Ubuntu20.04 based docker image was added to: [1]. [1] https://github.com/GoogleContainerTools/base-images-docker/blob/master/ubuntu2004/

I also figured, that we could build Ubuntu 20.04 compatible image by just saying: Dockerfile ```dockerfile FROM gcr.io/cloud-marketplace/google/ubuntu2004:latest RUN apt-get -y update && \ apt-get -y install git && \...

Seeing the same warnings, after building and using image based on rbe_ubuntu_18.04 image: ``` $ bazel test --config=remote javatests/com/google/gerrit/integration/git/... INFO: Invocation ID: 22941356-4131-494c-9fe7-f0ac3c174398 DEBUG: /home/davido/.cache/bazel/_bazel_davido/5c01f4f713b675540b8b424c5c647f63/external/bazel_toolchains/rules/rbe_repo/version_check.bzl:59:9: Current running Bazel is not...

The revert was submitted: https://gerrit-review.googlesource.com/c/gerrit/+/274335. Let's see if this would break Gerrit build on Buildkite again.

> The proposed changes could break those tools in the interim. I don't see how this is possible. A tool `foo` uses version `bar` of JUnit, where assumption violation is...