David Ostrovsky
David Ostrovsky
As pointed out in my previous comment, the inspiration could be the current implementation of VanillaJavaBuilder.java#run:[1] method that is calling vanilla `javac`: ```java CompilationTask task = javaCompiler.getTask( new PrintWriter(output, true),...
I also start seeing it after migration to 5.1.0: ``` $ bazelisk build tools/node_tools/... [...] ERROR: /home/davido/projects/gerrit/tools/node_tools/polygerrit_app_preprocessor/BUILD:7:11: Compiling TypeScript (prodmode) //tools/node_tools/polygerrit_app_preprocessor:preprocessor failed: (Exit 1): tsc_wrapped.sh failed: error executing command (from...
Thanks @Yannic. Would it be an option to implement that check in `bazel_skylib`, as this use case may be interesting for other projects as well. @laurentlb Not all users and...
FTR: Starting from Bazel release 2.0.0 bazel shell script was extended to perform the version check. FWIW, Gerrit project removed the version check entirely.
@philwo Is there any plans to backport Shellzelisk from 2a8cc7075f741721563efd9dc050ca3458cde30b to Windows? If not, would it make sense to include Yannic's version check to check against `.bazelversion` in some common...
@Yannic Can you upload your rule (or extend the existing `check_version` rule) to check against the content of `.bazelversion` to `skylib` repository?
> Maybe. This can be decided on skylib repository (PR or issue). @laurentlb Can you move this issue to `skylib` repository? It seems, that I can not do it.
See also: https://github.com/bazel-contrib/rules_jvm/issues/23.
> Error Prone is more decoupled from Bazel than when this issue was first filed, it's possible (but not super convenient) to rebuild java_tools with a newer version of Error...