David Ostrovsky

Results 153 comments of David Ostrovsky

@shs96c > If we can expose the Google Format command as a *_test rule, then this will be easy to add. I still don't get how `bazel test gjf-check` would...

> But I'm leaving this issue open just in case this analysis/discussion is ever of any use to others in the future. I think the main reason to move `google-java-format`...

This is currently not supported. @lucamilanesio Are you aware of any workarounds?

Actually multiple domains should be supported. See, for example the latest version documented here: https://github.com/davido/gerrit-oauth-provider/blob/master/src/main/resources/Documentation/config.md ``` plugin.gerrit-oauth-provider-google-oauth.domain = "mycollege.edu" plugin.gerrit-oauth-provider-google-oauth.domain = "myschool.net" ``` The code that handles the request for...

Could you just repeat the setting with: ``` domain = "foo" domain = "bar" ``` Then try to authenticate with two different users from the domain `foo` and domain `bar`....

If we will do that change, we would need some kind of data migration.

So yes, now the problem is even more serious, because we have to change first to API v2 to start getting the data again. We have this [PR](https://github.com/davido/gerrit-oauth-provider/pull/128), that I...

Can you try without IAP ro confirm that session expiration issue is related to IAP? Refresh access token is not implemented: [1]. [1] https://developers.google.com/identity/protocols/OAuth2WebServer#offline

OAuth 2 authentication scheme integration for Gerrit doesn't support groups.