David Ostrovsky

Results 53 comments of David Ostrovsky

> Let's just have assumption failures print out an "I" Fine, I will look into it.

> Can you give us an example of a build tool that relies on JUnit text UI to report test outcome. [Bazel](https://bazel.build/), see my analysis in this issue: https://github.com/bazelbuild/bazel/issues/3476.

My analysis was, that for its own output rendering standard log file produced by JUnit text UI is used. Ant-Style XML is produced for consumption by/integration with external tools.

> In any case, I don't think we should change the meaning of the methods in Result.getIgnoredCount() so it starts including assumption failures. The whole assumption violation outcome was completely...

> Running bazel build at the root doesn't seem to do much. I'm not following. `bazel build` does a lot here: ```shell $ bazel build //... [...] $ bazel test...

> Bazel being less ubiquitous than Maven and Gradle, it'd be nice if there were some build instructions in the CONTRIBUTING.md page Every Bazel build instructions are three liners: -...

@ronshapiro I added this [issue](https://github.com/bazelbuild/continuous-integration/issues/632) to build flogger on Bazel CI to avoid unnoticed breakages like the one you fixed in: [1]. [1] https://github.com/google/bazel-common/issues/37

@shs96c JavaBuilder is Bazel wrapper around Javac invocation, that does some magic: * Error Prone integration * strict dependency checking * reduce classpath magic However, in very recent Bazel version...

If I try to pass: `bazel build --define=ABSOLUTE_JAVABASE=/usr/local/bin/infer`, then it doesn't work, as Bazel tries to add `bin/java` to this Java home directory: ``` java.io.IOException: Cannot run program "/usr/local/bin/infer/bin/java" (in...

@cushon Any idea, how we could hijack `javac` to call `infer` in Bazel driven build? The problem is, that before switch from Buck to Bazel JGit/Gerrit community was able to...