Lion - dapplion

Results 385 comments of Lion - dapplion
trafficstars

> To have separate private package for just for testing We use to have this and it's not great. Tests should be placed in the package that has all the...

> somewhat related: #4031 Not a private package, but test utilities def could be better organized for reuse The initial idea of that package is to generate blocks and attesations...

@wemeetagain is there any specific reason to bump besides the types? Check the changelog if there many changes that we want

@mpetrunic could you comment in what situations Lodestar may throw this error? Why could the bootnode keypair wrong? I'm not familiar with noise internals

Error is decorated here `Error: Error occurred during XX handshake`: - https://github.com/ChainSafe/js-libp2p-noise/blob/1e3d20738c90d68133011a59bb5054138ee9e2b5/src/noise.ts#L195 `Error occurred while verifying signed payload`: one of this three places, which one? - https://github.com/ChainSafe/js-libp2p-noise/blob/1e3d20738c90d68133011a59bb5054138ee9e2b5/src/handshake-xx.ts#L103 - https://github.com/ChainSafe/js-libp2p-noise/blob/1e3d20738c90d68133011a59bb5054138ee9e2b5/src/handshake-xx.ts#L138 -...

@g11tech It needs the genesisValidatorsRoot for the export https://github.com/ChainSafe/lodestar/blob/266f9e2f4418676c9b070bd0f64d1a755cb8e38e/packages/validator/src/slashingProtection/interchange/formats/v5.ts#L13-L18

> i think for the known networks we know this value https://github.com/ChainSafe/lodestar/blob/unstable/packages/light-client/src/networks.ts, so guess we can skip thinking Using known values for common networks is a great idea! Feel free...

> Regarding loading a state from db, iirc this is expensive, like 6+ seconds. Might be good to benchmark this and get this lower. In terms of time to result,...

> Maybe you can help them with converting to typescript / adding types see_no_evil The API of both libraries is extremely simple we can lock version and type ourselves. This...