Lion - dapplion

Results 354 comments of Lion - dapplion

See this CPU profile showing the bottleneck in performance. ![Screenshot from 2021-03-24 09-08-26](https://user-images.githubusercontent.com/35266934/112276190-c1cbe600-8c80-11eb-9578-5b9275a88b4e.png) ![Screenshot from 2021-03-24 09-08-48](https://user-images.githubusercontent.com/35266934/112276196-c4c6d680-8c80-11eb-8b55-f4291ee38d7c.png)

After refactoring peer managment in Lodestar I strongly believe moving from a class PeerId to a string as canonical identifier should be a priority. It would simplify the codebase significantly...

@mcdee The main reason is not the JSON cost itself but > non-trivial cost to the response Which is mapping validator indexes to serialized pubkeys. At least Lodestar only has...

RE @mcdee > should /eth/v1/lightclient/snapshot/ only take a block root, or should it allow the more generic block ID? Rationale behind this would be to allow simple retrieval of the...

RE: @arnetheduck > This is great as a draft, but believe it's good to settle on a p2p protocol before enshrining / merging it such that implementations don't have to...

> It would be useful if all requests support returning SSZ data if the `Accept: application/octet-stream` header is provided. To make this possible, we need to specify an upper limit...

After discussing with @etan-status its best to separate the proof route into a different namespace TBD

- Closing for https://github.com/ethereum/beacon-APIs/pull/247 which is a superset of this PR's functionality Proofs endpoint should be tackled separately

To update, on Lodestar side we implement pagination in the consumer by querying only N items per request. Most of the requests have a predictable size so it's a stable...

@sohkai I have reviewed the items that you proposed to test and I have a few doubts: - Regarding `AppProxyFactory.newPinnedAppProxy(IKernel, bytes32)` are you referring to `newAppProxyPinned`? https://github.com/aragon/aragonOS/blob/d10d195387269e8d51d0aa3e608ec44ecb9b8173/contracts/factory/AppProxyFactory.sol#L38 - Regarding `EVMScriptRunner.protectState`,...