lodestar icon indicating copy to clipboard operation
lodestar copied to clipboard

Published 20 hours ago • verified publisher icon ChainSafe

Upgrade fastify to v4.x

Open wemeetagain opened this issue 2 years ago • 5 comments

Currently at 3.x

The dependencies (fastify-cors, etc) and their types are not great, should all be updated

wemeetagain avatar Jun 28 '22 22:06 wemeetagain

@wemeetagain is there any specific reason to bump besides the types? Check the changelog if there many changes that we want

dapplion avatar Jun 29 '22 13:06 dapplion

I had problems during #4114 with their types

wemeetagain avatar Jun 29 '22 14:06 wemeetagain

Also seeing this at startup time:

(node:1506517) [FST_MODULE_DEP_FASTIFY-CORS] FastifyWarning.fastify-cors: fastify-cors has been deprecated. Use @fastify/[email protected] instead.

wemeetagain avatar Jun 29 '22 17:06 wemeetagain

We should discuss the priority on this one @dapplion

philknows avatar Jul 01 '22 14:07 philknows

FYI you don't have to update to 4.x to fix that. You have versions here https://github.com/ChainSafe/gavel-server/pull/1/files if you want to stay at version 3.

Not sure how stable 4.x is since they released it a month or two ago and they seem to be pushing a lot of fixes.

mpetrunic avatar Jul 11 '22 09:07 mpetrunic

Already updated to 4.15.0.

wemeetagain avatar May 26 '23 18:05 wemeetagain