Lion - dapplion
Lion - dapplion
Thank you so much for your answer @sohkai. I have opened a PR https://github.com/aragon/aragonOS/pull/542 testing item 2 `EVMScriptRunner.protectState`. I still have doubts regarding the other items: - `AppProxyFactory.newPinnedAppProxy(IKernel, bytes32)` is...
@sohkai Thanks for the recommendation. I have tested - `newAppProxy(IKernel _kernel, bytes32 _appId)` and - `newAppProxyPinned(IKernel _kernel, bytes32 _appId)` in a new file covering the last remaining untested line. Let...
According to coveralls, the only file with remaining lines/branches to be tested is [SafeERC20.sol](https://coveralls.io/builds/25223308/source?filename=contracts%2Fcommon%2FSafeERC20.sol) I see you discussing coverage decrease in https://github.com/aragon/aragonOS/pull/541, may it be that SafeERC20.sol should be ignored...
@sohkai I have written extra test to cover `SafeERC20` and get coverage to 100.00%. However, the Travis build on my fork's branch completes the coverage step successfully https://travis-ci.com/dapplion/aragonOS/builds/125316450 but on...
@cgewecke Bumped the version of `solidity-coverage ` to `0.6.7` and fixed the problem. Thank you for your insight!
@sohkai The Travis build on my fork's branch completes the coverage step successfully https://travis-ci.com/dapplion/aragonOS/builds/125316450. However, on your repo it doesn't, where it errors with: ``` Writing artifacts to ./build/contracts Instrumenting...
@cgewecke helped solve the problem and now of CI tasks complete successfully
> Could someone point me to an ELI5 of how the withdrawal process will work for the end user? After reading the specs, its not clear to me how the...
@Nashatyrev Thanks for leading this work, but does a MAXIMUM_CONCURRENT_REQUESTS param communicate an expectation of rate limiting requirements? I imagined some rough numbers denoted as request count per time unit.
> i think if we want to change this name it would something more like `FOO_GENERALIZED_INDEX` as it is not immediately clear what a "gindex" is whereas an "index" (of...