Lion - dapplion

Results 393 comments of Lion - dapplion
trafficstars

Noting another issue with backfill sync: Backfill sync sources blocks and blobs / data columns from peers with the _by_range RPCs. We bundle those results in an RpcBlock and send...

Some extra notes for > Assume all finalized peers are in the same chain and improve SyncingChain grouping Problem: - Peers are scattered between different syncing chains if not everyone...

Updated tests to assert a syncing chain is created. Plus removed down-scoring the peers for a long chain https://github.com/sigp/lighthouse/blob/4ec5594f4bf507b54542cf9a6b2943b322c90460/beacon_node/network/src/sync/block_lookups/mod.rs#L294-L299 As a final item we could check that for a syncing...

Can you upload the logs to the CI run artifacts? To debug failures

I don't follow exactly what problem is this trying to address, could you expand more on the motivation?

> We just need to be careful here because ultimately required -> optional == breaking change to a published interface... Yes indeed, this PR intends to gauge support if a...

> As a rule, i'd be against this, it really doesn't accomplish anything useful, and is a breaking change by definition, so that's my reasoning. - Ok, let's leave this...

> On Nimbus, there is branch feat/splitview which pulls in blocks via BeaconBlocksByRoot in a backward motion, from peers specifically advertising unknown branches. If the branch is long you can...

Still something I am pursuing to be included in the specs