Lion - dapplion
Lion - dapplion
Closing for now if this is not needed immediately. We definitely want to bump fastify to v4 eventually tho
> basedir=$(dirname "$(echo "$0" | sed -e 's,\,/,g')") Where is this coming from? I don't see this in the codebase
Related - https://github.com/ChainSafe/lodestar/pull/3183 - https://github.com/ChainSafe/lodestar/issues/3182
- Likely caused by https://github.com/ChainSafe/lodestar/issues/4002
If we lock a dependency to an exact version `"some-dep": "0.1.0"`, but `some-dep` depends on a range: `"bad-dep": "^1.0.0"` and `bad-dep` gets compromised, are we vulnerable?
> the answer is yes you are still vulnerable if you dont have this in your yarn.lock. yarn.lock's mostly fix this issue However if a consumer installs lodestar via NPM...
Reducing to prio-medium after only recommending docker installations. @dadepo could you drop an update of your efforts regarding this?
More disabled tests https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/api/impl/beacon/state/fork.test.ts#L9-L10 https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/api/impl/beacon/pool/pool.test.ts#L25-L26 https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/api/impl/debug/index.test.ts#L20-L21 https://github.com/ChainSafe/lodestar/blob/5d086b58a20f57c69f1d2cc90d5bf785f851f535/packages/lodestar/test/unit/chain/factory/block/blockAssembly.test.ts#L21-L22
It also breaks with a different error ``` ERROR in /home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/electron-fetch/lib/index.es.js Module not found: Error: Can't resolve 'electron' in '/home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/electron-fetch/lib' @ /home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/electron-fetch/lib/index.es.js 1262:13-32 @ /home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/ipfs-utils/src/fetch.js @ /home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/ipfs-utils/src/http/fetch.browser.js @ /home/lion/Code/dappnode/DNP_DAPPMANAGER/node_modules/ipfs-utils/src/http/fetch.js @...
https://github.com/dappnode/DNP_DAPPMANAGER/blob/60ac93345872a9b8f66bd1ac63b7b620dddabe65/packages/dappmanager/package.json#L91 ``` "webpack": "^4.43.0", "webpack-cli": "^3.3.11" ```