Damian Nolan

Results 57 comments of Damian Nolan

Thanks for the detailed response @AdityaSripal

Adding needs discussion label as this will not be required immediately. cc @AdityaSripal

@neitdung I've assigned you to the issue! Thank you very much

I think it's good to assign a `logger` variable if its used more than once in the same function. But needless if it's used only once. Would you agree?

Awesome, thanks for this @alexanderbez! I figured this was the case with tx search alright, but just noticed the case of no way to get at events via the CLI...

I assume the hyperspace relayer must have client update functionality built in somehow as there is already successful happy path transfer tests using cosmos chains polkadot. I'm guessing that it...

Thanks, I'll open an issue upstream as well 👍

@chatton is this issue addressed now?

I suspect removing the non-hex encoded event attributes in https://github.com/cosmos/ibc-go/pull/6023 has something to do with this. Assuming that this test users hyperspace relayer its possible that they do not use...

Hex encoded event attirbutes are not used. https://github.com/ComposableFi/composable-ibc/blob/master/hyperspace/cosmos/src/events.rs#L526-L531 https://github.com/ComposableFi/composable-ibc/blob/master/ibc/modules/src/core/ics04_channel/events.rs#L43 opened: https://github.com/ComposableFi/composable-ibc/issues/494