Damian Nolan

Results 57 comments of Damian Nolan

When the code PRs are all merged we should: - [ ] Address any TODOs in the code linking to this issue! (#7058) - [ ] Update all documentation code...

This is part of plans for the `api` pkg so would might not be the best use of time to do this with `clienttypes.Height` but essentially the task is still...

Happy to discuss this, I do agree that its kind of weird to inject it via the interface method on `AddRoute`. It might just be cleaner to give it to...

> Importing this implementation should capture all cases https://github.com/celestiaorg/nmt/blob/master/proof.go I'm curious if we should be rather using [`ShareProof`](https://github.com/celestiaorg/celestia-core/blob/main/proto/tendermint/types/types.proto#L211) or if the raw nmt proof is the desired option?

Hey @nashqueue, I've looked into duplicating the 07-tendermint and modifying some parts to create a celestia (da client) which rollkit clients written as wasm contracts will call back to. In...

Agree! Simplifying it to only use as a DA client for rollup clients is probably the way to go. We can just remove the protobuf `oneof` type and unmarshal only...

So far so good, looks pretty sweet to me. Definitely in favour of removing the interfaces like `Height` and `Path` and bringing over the concrete types to `api`. The concrete...

Should this be merged or closed? Or migrated elsewhere for the time being. I'm also fine with leaving it sit. Just doing some housekeeping 🧹

Agreed. The sequencer would need to put the same celestia address into the `Blob` signer as the account who's paying and signing for the `PayForBlobs`. In that approach the blob...

Awesome! Thank you @rach-id, I'll check it out