ibc-go icon indicating copy to clipboard operation
ibc-go copied to clipboard

Fix grandpa e2e tests

Open crodriguezvega opened this issue 1 year ago • 3 comments

The grandpa e2e tests have started to fail.

crodriguezvega avatar Apr 30 '24 07:04 crodriguezvega

I suspect removing the non-hex encoded event attributes in https://github.com/cosmos/ibc-go/pull/6023 has something to do with this. Assuming that this test users hyperspace relayer its possible that they do not use the hex encoded event attributes.

damiannolan avatar May 06 '24 13:05 damiannolan

Hex encoded event attirbutes are not used.

https://github.com/ComposableFi/composable-ibc/blob/master/hyperspace/cosmos/src/events.rs#L526-L531 https://github.com/ComposableFi/composable-ibc/blob/master/ibc/modules/src/core/ics04_channel/events.rs#L43

opened: https://github.com/ComposableFi/composable-ibc/issues/494

damiannolan avatar May 06 '24 13:05 damiannolan

yay, nice find, @damiannolan! Thank you also for opening the issue in composable-ibc.

crodriguezvega avatar May 06 '24 20:05 crodriguezvega

look nice

navyxie avatar May 08 '24 06:05 navyxie

ah yes, we use yet another relayer here. I'll see if this is an easy lift to fix in hyperspace.

DimitrisJim avatar May 15 '24 05:05 DimitrisJim

Fixed by disabling them 😓 We will go with https://github.com/cosmos/ibc-go/issues/6835 instead.

crodriguezvega avatar Aug 09 '24 14:08 crodriguezvega