ics23 chore: Update proto builder and rust

Aug 24 '23 15:08 faddat

Walkthrough

The recent updates across various modules primarily focus on optimizing the logging process by eliminating local logger instances and directly using the logger from the keeper. This change standardizes logging calls and potentially improves performance by reducing redundancy. The modifications span across functions handling packet processing, channel capabilities, and consensus state pruning.

Changes

File Path	Change Summary
`.../27-interchain-accounts/controller/keeper/migrations.go` `.../27-interchain-accounts/host/ibc_module.go` `.../27-interchain-accounts/host/keeper/handshake.go` `.../transfer/ibc_module.go`	Updated logging to use `keeper.Logger` directly, removing local logger instances. Changes affect error and info logging across packet processing and channel operations.
`.../light-clients/07-tendermint/migrations/migrations.go`	Refactored logging in `PruneExpiredConsensusStates` to use `clientKeeper.Logger` directly, enhancing the logging approach during consensus state pruning.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai generate interesting stats about this repository and render them as a table.
- @coderabbitai show all the console.log statements in this repository.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

May 07 '24 04:05 coderabbitai[bot]

I think it's good to assign a logger variable if its used more than once in the same function. But needless if it's used only once. Would you agree?

May 07 '24 08:05 damiannolan

@damiannolan, I'd say it's good to assign a logger variable if it is passed down to another function or something like that. I understand assigning a variable might a a little more efficient. But in practice, while reading code, we ignore all logger related code, so reducing its surface area feels good to me.

I'm happy to adjust the PR so that it only removes logger variables which are used only once if others want that instead