Damian Nolan

Results 57 comments of Damian Nolan

Some other notable things: - [x] Changes to simapp (root.go) - [x] Basic Manager removal - [x] AnteHandler consolidation - [x] Protobuf generation (updating of any opt for cosmos/gogo changes)...

Capabilities usage should now be removed from each of the core msg server handlers. Other places to remove references: - [ ] Expected interfaces `Authenticate` - [ ] Usage in...

We will need to add protobuf messages for this and a state key `packetID -> ackResults`. I considered using plain go types but we generally store protobuf encoded bytes in...

Awesome that you already have some sample code and an issue for this @chatton! Great work! Did you ever get to signing a tx within an e2e test? I assume...

Added tentatively to v10 milestone

There looks to be some failing unit tests here

Let's hold off on merging this until we understand why this change broke our tests: ![image](https://github.com/user-attachments/assets/0df30197-e6db-438b-9c48-dca9d4d0a112) cc. @julienrbrt @tac0turtle I'm unsure what the implications of this change really means, so...

> do we want to keep open? would assume there would be a patch release for this at some point? Yeah I think we can keep it open. There is...

There will be a new patch release this week. I'll update this PR when it becomes available. Converting to draft for now