Damian Nolan
Damian Nolan
if we're going to add these checkTx variants for different msgs, might be worth sweeping them all into an `abci.go` or `ante.go` file somewhere in core. We can handle that...
Thanks @DimitrisJim! Happy to leave this open or switch to draft. Likely won't need to merge this if we don't need protov2 and can use gogoproto.
This can be closed as pulsar is no longer required. see https://github.com/cosmos/cosmos-sdk/issues/20134
> Seems like these arguments can just be constructed inside the methods we call instead of passing them as args. Open this issue here to keep track, would be nice...
Off the top of my head, I'm thinking we could potentially replace the wasm keeper's clientKeeper entirely with store provider? Would need to look at it more and come back...
@crodriguezvega closing!
If I understand correctly, we use the following in pretty much all query cmds: ```go flags.AddQueryFlagsToCmd(cmd) ``` This should add the default query flags from the sdk, one of which...
Going to work on this some more soon and start adding ibc modules to app config! 🚀
We should also test ledger support since `MsgTransfer` is being modified. I will add to the checklist on the issue
> Document also the change of `Path` to `commitmenttypesv2.MerklePath` if we finally decide to make it ([ref](https://github.com/cosmos/ibc-go/pull/6644/files#diff-bd0618ba11fca65b87c57f68bf9cbba25ee07b82cc8bb56579744709a2e27d11)). We can use this as reference: https://github.com/cosmos/ibc-go/pull/6757