Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

I think I mostly agree with this. Internally at Google we only enable `ERROR` level checks at build-time, because warnings make the build log verbose and people tend to ignore...

It would be helpful to have a more minimal reproducible example, for example a small self-contained example using the Error Prone CLI (https://errorprone.info/docs/installation#command-line)

Hi, I'm not sure I understand what the proposal is. This is the repository for Error Prone. We already run Error Prone checks on this codebase. Can you clarify what...

> Can you clarify what the proposal is here? Do you want to integrate Error Prone into something? Or add support for a specific feature to Error Prone? Or something...

As best I understand the suggest here it is to perform a code cleanup of Error Prone's own source code, using openrewrite rules, including ones that run Error Prone Support...

I cleaned up some of the occurrences of `!optional.isPresent()` -> `optional.isEmpty()` using Error Prone's version of that refactoring in https://github.com/google/error-prone/commit/22c7428b75b8177e7b6d0433b65197e80e8e6cdb

Could you provide a minimal reproducible example using the Error Prone CLI (https://errorprone.info/docs/installation#command-line)?

It's hard to say without a minimal self-contained repro.