Liam Miller-Cushon

Hi @Stephan202, Thanks for the PR! I was taking a fresh look at this, it seems like a nice thing to support. I was trying to think a bit about...

I'm not sure if there's a way to do this without overriding visitor methods that only exist on newer JDK versions, which I don't think we can't use until the...

> Google-java-format when using AOSP style will reformat code that was already formatted by Google's Android Studio for Platform IDE (and vice versa). Both styles are compliant with the guidelines...

I think the default Android Studio behaviour is using IntelliJ's formatter with a configuration to follow AOSP style. This is related to the discussion of `java-google-style.xml` in #695. The source...

> It's my understanding from the style guide that users are expected to adhere to the configuration that Google generates (either through ASfP defaults or `aidegen`): [We expect that as...

Thanks, 'no longer returns null' could have been something like 'no longer returns null *when the standard streams are redirected or connected to a virtual terminal*' Can the implementation return...

SGTM overall. I'm undecided about whether this is something we'd want to warn on by default, or have be opt-in. Another possibility would be to have a more aggressive version...

I agree that ident is a bug, although I'd also encourage code following Google Style to use the 'typical' fall through comment the style guide suggests which is the line...

If you disable this check (with `-Xep:UnsafeWildcard:OFF` or `@SuppressWarnings("UnsafeWildcard")`), does the compilation succeed, or does a different error get reported?

Interesting, thanks for following up! I'm going to close this out, but please let us know if you see it again or it starts reproducing consistently.