Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

cc @philwo related: https://groups.google.com/forum/#!topic/bazel-discuss/13uPDObyfQg

For the target `--javabase` it's easy an necessary to support a range of JDKs because our toolchain supports cross compilation: users expect to be able to use Bazel to target...

Note that this is currently a preview feature, there's a draft JEP to finalize the feature in Java 25: https://openjdk.org/jeps/8344700

The style guide update for module imports is still TBD, but that should happen in time for the Java 25 GA. It's possible it will discourage module imports in favor...

I pushed a release that adds support for `import module`. The style guide will be updated to disallow `import module` (similar to how wildcard imports are disallowed): https://github.com/google/styleguide/pull/946

g-j-f will preserve them. It doesn't have enough information to expand them even if we wanted to do that in the formatter. That might be something we'd add to Error...

The formatter has support for those features: ``` $ java -jar google-java-format-1.22.0-all-deps.jar T.java package com.google.errorprone.bugpatterns; class T { private static void add(JsonNode jsonNode, String key, V value) { switch (value)...

Does passing `-XepDisableWarningsInGeneratedCode` help?

To confirm, it sounds like the report is that given a TODO like: ``` // TODO: We still have a lot of work to do here. We still have a...

Thanks for the report. The wrapping of long string literals is handled as a separate pass (`--skip-reflowing-long-strings`), and I think it's making non-AOSP assumptions instead of passing in the configuration....