Liam Miller-Cushon

> I have realized this approach doesn't work for all cases, because there are public APIs that allow accessing type annotations on an `ExecutableElement` that don't result in the underlying...

Thanks for taking another look, and I'm happy to write up a CSR. (If we go with a warning I would like to consider putting it in an `-Xlint` category,...

> I am not sure if we could attach TAs on classes eagerly. The feedback I've heard about these diagnostics has been for the field/method cases. I understand the use-case...

/touch I'm still unsure what the best approach here is. > in practice the issues that have come up are all with method (and maybe fields), but not classes. I...

Another place this could be informed by the specification is the specification of runtime behaviour when loading and linking classes with references to missing classes. I don't have as good...

> I wouldn't oppose a warning to make all non-override methods in an anonymous class private, even without detecting this edge case To double-check, making it `private` is safe even...

Many of the results I've found so far are things that are used reflectively. I added handling for `@Keep` (and annotations that are meta-annotated with `@Keep`). There are some more...

It turns out that https://errorprone.info/bugpattern/UnusedMethod already handles these and will suggest deleting them if they're actually unused. I am still looking at doing something about the modifiers, though.

/contributor add @minborg

Thanks for the review! > I think we should put some more care when going to char-based indices to byte array indices, esp. if we will optimize the UTF16 case...