Liam Miller-Cushon

Results 378 comments of Liam Miller-Cushon

Thanks, I agree the example with one parameter can be surprising. The rationale for the indentation is to make it easier to scan signatures with multiple parameters, e.g.: ```java void...

One drawback of only indenting the type is that if the annotations are all at the same indent, it's hard to scan to see how many parameters there are, especially...

[For posterity I dug up some discussion in b/257119244 which discussed some of the same options, and was leaning towards leaving the current formatting as-is]

Thanks for the report! > Can you please add the RestrictedInheritance annotation and checker to the error-prone artifacts? or hide the private annotation from the public API. We may eventually...

The issue with `play-services-base` should have been fixed in version 18.6.0

(This is also tracked by internal bug b/382713504)

This is related to [this FAQ entry](https://github.com/google/google-java-format/wiki/FAQ#i-ran-it-in-change-only-modified-lines-mode-but-it-reformatted-lines-i-never-touched). It can't reformat arbitrary regions of the program, it always reformats entire sections, so it expands `--lines` to include the sections that it...

I spent some time trying to create a reproducer and so far haven't been able to reproduce outside the build machine where I first saw it, it's still reproducing consistently...

> Do you know how the defaults for MaxRAMPercentage are supposed to be computed here? Perhaps here? https://github.com/oracle/graal/blob/8ad5cf768bd8f6e661e2e51b197ddc95b9fbfe31/substratevm/src/com.oracle.svm.driver/src/com/oracle/svm/driver/MemoryUtil.java#L81C20-L81C45 Looking at that logic, I see handling for the environment variable `CI`....

Sorry I'm not sure I'll have time to contribute a fix for this.