Liam Miller-Cushon

Results 183 comments of Liam Miller-Cushon

(on preview, I'm mostly agreeing with @orionll) It's true that the module that includes `javax.annotation` isn't included in the "default set of root modules", but it's still part of the...

``` java.lang.AssertionError at jdk.compiler/com.sun.tools.javac.util.Assert.error(Assert.java:155) at jdk.compiler/com.sun.tools.javac.util.Assert.check(Assert.java:46) at jdk.compiler/com.sun.tools.javac.comp.DeferredAttr$2$1.setOverloadKind(DeferredAttr.java:172) ``` That looks like [JDK-8210483](https://bugs.openjdk.java.net/browse/JDK-8210483).

cc @iirina The bug is fixed in the JDK 12 javac, which I think will be available in an upcoming Bazel release. It would also be possible to backport to...

@ajrepp are you sure the failing action is using the expected JDK version? If you run with `--verbose_failures` to get the command line for the failing action, and then run...

So internally I think we're relying on tools like Proguard processing their inputs to discover any `META-INF/proguard` entries, we don't rely on the build system to unpack them and pass...

cc @ahumesky for plans on r8 support > Do you know if it also does that for proguard.txt in AARs, too? I'd guess so, but didn't see it in that...

@damienmg has been creating a procedure for rolling out breaking changes that we'll follow for Error Prone once it's ready. The tentative plan is to leave it enabled by default...

That's the motivation for the policy @damienmg is working on for backwards incompatible changes.

EP is decoupled from Bazel in the sense that it's part of the `java_tools` archive. Is the idea that we seed that as an implementation detail, and since a Bazel...

> except in order to satisfy an API external to the compilation unit Arguably there's still *some* signal in that case, it might be worth checking to see if there's...